adokter / bioRad

R package for analysis and visualisation of biological signals in weather radar data
http://adokter.github.io/bioRad
Other
28 stars 16 forks source link

Rename aloft bucket to `aloftdata` #622

Closed peterdesmet closed 11 months ago

peterdesmet commented 11 months ago

As part of updating our infrastructure for the processing and storage of European vp/vpts data, we (unfortunately) had to recreate the s3 bucket where data are stored. It now has the name aloftdata rather than aloft. This PR updates functions and tests that access the bucket (I also made some minor suggestions to NEWS.md).

Note that in the current 0.7.1 version of bioRad, list_vpts_aloft() will generate URLs of the form https://aloft.s3-eu-west-1.amazonaws.com, while this update will have the function return https://aloftdata.s3-eu-west-1.amazonaws.com URLs. The old aloft bucket will still be accessible for the next 6 months, but accessing data will be slow and new data will not be added. So it depending on use, it might be worth releasing a 0.7.2 hotfix in the coming months.

https://aloftdata.eu/browse already points to the new bucket.

codecov[bot] commented 11 months ago

Codecov Report

Merging #622 (f93eb5b) into master (7a6cfdf) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head f93eb5b differs from pull request most recent head 154cbd2. Consider uploading reports for the commit 154cbd2 to get more accurate results

@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files          61       61           
  Lines        3699     3699           
=======================================
  Hits         3038     3038           
  Misses        661      661           
Impacted Files Coverage Δ
R/list_vpts_aloft.R 100.00% <100.00%> (ø)
adokter commented 11 months ago

@iskandari let's plan a hotfix release on CRAN in the next few weeks to get this PR on CRAN