adolfintel / Clock31

Clock + Calendar combo widget for Android
https://fdossena.com/?p=clock31/index.frag
GNU General Public License v3.0
24 stars 3 forks source link

Widget Crashed #1

Closed HonestAbe7 closed 1 year ago

HonestAbe7 commented 1 year ago

Thank you for your effort in making a clock and calendar widget. Unfortunately, the widget crashed when I tried to place it on my screen. I am using Android 10. Looking forward to your next version release. Thanks

adolfintel commented 1 year ago

Can you provide some more info? What phone and rom are you using? Does it crash before or after asking for calendar permission?

moriel5 commented 1 year ago

While testing Clock 31, I have also face the same thing, once the Calendar permission was granted (although I did forget to test what would happen if I did not grant the permission).

Device: Razer Phone 2 ROM: Android 9, Stock (extremely close to AOSP).

Update: I just tested denying the calendar permission, with the same end result. Interestingly, after granting the permission (and an accompanying crash) and revoking the permission, attempting to put the widget on the homescreen brings a crash, before asking for the permission (with the confirmation pane remaining on screen after the crash).

adolfintel commented 1 year ago

Alright, I'll change that code and release an update in the next few days

adolfintel commented 1 year ago

I just commited a change to the widget creation code, here's a test APK in case you don't have Android Studio installed: app-release.zip

Let me know if it works.

HonestAbe7 commented 1 year ago

Thanks but the updated file still crashes on my phone.

adolfintel commented 1 year ago

Do you have Android Studio installed so we can check logcat?

HonestAbe7 commented 1 year ago

No I don't. Do I need to download it and if so where?

adolfintel commented 1 year ago

First, remove Clock31 from Settings > Apps.

You can get Android Studio here: https://developer.android.com/studio/ Once installed, download this repo, open it in Android Studio, connect your phone with USB debugging enabled and you should see logcat at the bottom. Press the run button at the top, it will complain about being unable to launch the activity (it's a widget, it has no main activity) but it's installed, add the widget to your home screen and see what happens

Example: image

HonestAbe7 commented 1 year ago

Thanks but I will not have the time to invest to do this nor do I want to use a computer. I am sure there is a way to log issues some other way. I do hope you can get this resolved as it would be nice to see this widget. Thanks

moriel5 commented 1 year ago

@adolfintel No changes here either.

I generally use a rooted phone (with a custom ROM), however since I have not yet had the time to do here, when I'll be on my desktop later, I'll get the log output via ADB (I do not believe that I need Android Studio for this, and I am comfortable with with the command line to do this, especially since I run Linux).

HonestAbe7 commented 1 year ago

Just saw your reply up top. I am using an LG phone with Android 10.

Thanks for looking into this.

adolfintel commented 1 year ago

Added a couple of checks in case there are no clock/calendar apps installed. Test APK: app-release.zip

moriel5 commented 1 year ago

@adolfintel Sorry I wasn't able to check anything earlier as I had fallen asleep (it was towards the end of the night, and I was taking care of chores).

That last APK works as it should, after an initial crash the first time, when it asks for the Calendar permission.

Perhaps it is because I had disabled (via ADB) almost all of the Google apps on there (when replacing the ROM, I generally also run GAPPS-less), sans a few like GBoard, that don't need the Play Services to function and I haven't yet manage to get a suitable replacement (FlorisBoard is coming along, however it is not yet ready, in my opinion).

I should be able to get logs pertaining that initial crash within the hour, so that is what I'll do.

adolfintel commented 1 year ago

Thanks, looking forward to seeing that log. I use a rom without google services too so I can definitely exclude it as the issue.

moriel5 commented 1 year ago

@adolfintel Yeah, sorry about not being clear, I had meant that because as part of those apps, I had also disabled Google Calendar, which means that there is no Calendar app enabled (technically, there should have also not been a clock app, however I needed to easily check the time in multiple timezones in order to know when is a good time to contact people I have ordered items from and/or make an international call, so I installed one that is based upon the AOSP clock from is GitHub source (the is a newer version on F-Droid)).

HonestAbe7 commented 1 year ago

Thanks for the update. It works just fine now. Any way to resize the date without it taking up the whole screen? What about changing colors? Thanks

moriel5 commented 1 year ago

@adolfintel I'm sorry about the delay and lack of notification. In the end I didn't have the time to take the logs earlier, and with each delay I thought that I would be able to within a few minutes.

Here are the logs (I tried to clean them up a little by removing unnecessary lines that do not not pertain to Clock31): Clock31 Log

Interestingly, the crashes have completely disappeared, with only a few milliseconds of delay during the initial placement of the widget.

Update: Odd of GitHub to add an extension to the file, much less replace the space with a dot.

adolfintel commented 1 year ago

Thanks for the log. There doesn't seem to be anything unusual in it, so I guess the couple of extra checks in the initialization process fixed the crashing.

I'll push an update soon