Notification icon very big

adolfintel / OpenPods

The Free and Open Source app for monitoring your AirPods on Android

https://fdossena.com/?p=openPods/index.frag

GNU General Public License v3.0

957 stars 161 forks source link

Notification icon very big #14

Closed 2xlink closed 5 years ago

2xlink commented 5 years ago

First of all: Thanks for the application, it is very useful :)

Secondly, I am not sure why the notification icon is so much larger than other icons on my phone. See here: Untitled2

I fixed it by resizing the notification_icon.png resource (maybe that could be the wrong approach …): Untitled

I can make a pull request if you want :)

Cheers

adolfintel commented 5 years ago

Wasn't this fixed like 2 months ago in commit f421e0febf639d6832e38fc9c4093dd6e8671db5 ?

2xlink commented 5 years ago

Well, not on my system at least ;) I am not entirely sure where the problem could stem from. I use a Samsung Galaxy S7 with the default interface, maybe they fucked something up with notification icon handling. I assume that the icon on your phone is the correct size?

nichbar commented 5 years ago

I can confirm that issue still exist on my oneplus 3T which is running android pie.

adolfintel commented 5 years ago

Ok, I'll scale down the icon a little bit

adolfintel commented 5 years ago

@2xlink @nichbar Can you test this APK before I release it? test.zip

nichbar commented 5 years ago

@adolfintel Here comes the screenshot

adolfintel commented 5 years ago

Looks good. I've also forced the colors in the notification to "fix" #13, waiting for feedback from that guy and then I'll push this to master

2xlink commented 5 years ago

Thanks, looking good :)

I had some thoughts about the icon, I think it looks a little bit like a musical note. What do you guys think of two airpods, like this: notification_icon

adolfintel commented 5 years ago

Looks good, want to send a PR?