General improvements - Githubissues

adolfintel / OpenPods

The Free and Open Source app for monitoring your AirPods on Android

https://fdossena.com/?p=openPods/index.frag

GNU General Public License v3.0

938 stars 161 forks source link

General improvements #46

Closed Domi04151309 closed 4 years ago

Domi04151309 commented 4 years ago

Changes:

Add content description to ImageViews for better accessibility
Unified padding and margin on activities with resource values
Toolbars with back buttons in SettingsActivity and AboutActivity for better user flow
Vector graphics instead of bitmaps for some icons
Fix notification bug with some devices that invert notifications on dark mode which causes a black notification background that doesn't match the default dark gray one.
Improves Android 10 dark mode support for notification

adolfintel commented 4 years ago

Wow, lots of improvements. I'll test this in the next few days and merge it. Thank you!

Domi04151309 commented 4 years ago

You're welcome! The notification bug could also be the reason for Issue #33

adolfintel commented 4 years ago

This PR will be merged in the next release (1.4)

Domi04151309 commented 4 years ago

When will this be merged?

adolfintel commented 4 years ago

@Domi04151309 In a few days. I'm currently working on an update for LibreSpeed, as soon as it's done I'll update OpenPods as well

Domi04151309 commented 4 years ago

It has been a few days now but it's understandable that it's not merged yet because it are strange times.

adolfintel commented 4 years ago

I know, I had planned to merge it one of these days but there has been a lot of delays. I live in Lombardy, in Italy, I'm literally scared that I'll run out of food, I'm too anxious to work on this, or any of my other projects.

rafsanjani commented 4 years ago

I got one issue with this branch. In Light mode, the percentage texts are not visible. They are visible in Dark mode however.

Samsung Galaxy Note 9 Android 10

adolfintel commented 4 years ago

Merged with #65