adolfintel / OpenPods

The Free and Open Source app for monitoring your AirPods on Android
https://fdossena.com/?p=openPods/index.frag
GNU General Public License v3.0
938 stars 161 forks source link

Android 10, Galaxy Note 10 - the app refuses to work if the location is turned off (while the permission is granted) #60

Closed maxim-saplin closed 4 years ago

maxim-saplin commented 4 years ago

This essentially requires having the Location turned on all the time - that was the reason why I refused to use the app. AirDroid from GPLay is OK with Location off.

P.S.: all that stuff with location permissions make a bad impression considering that app only aimed at showing battery level. I see that all GPLay Airpods apps require that permission. Though having some mode without location permission would be a killer feature to me (even if it'll require manual refreshing of the status of the app/battery).

jffernandez commented 4 years ago

Location is needed so the app can read BLE (Bluetooth Low Energy) packages, because that is the communication method for the device. Is not a problem with de apps but the Android API, someone decided to put that under Location permission, even when is not really related. You can have location off, then turn it on to see battery levels, then turn it off again.

maxim-saplin commented 4 years ago

Any chance to make it possible to check levels with Location OFF as with AirDroid?

jffernandez commented 4 years ago

To allow communication with any BLE device, like AirPods, you should grant Location permission (per Android API design), but maybe, once granted, communication is allowed with disabled location, here @adolfintel can help.

adolfintel commented 4 years ago

As @jffernandez said, android requires location permission to use BLE. I'm not collecting any data or anything, the app doesn't even have internet access.

I don't know how AirDroid is doing it without location permission, according to the android documentation, you can't. Can you make sure that what you said is correct?

Anyway, when I did some investigation on similar apps on google play last year, all of them had ads and/or analytics, so I definitely wouldn't install them unless you have a firewall installed (which is what I used to do before I made this app)

adolfintel commented 4 years ago

I'll close the issue for now but keep me posted if you find anything

maxim-saplin commented 4 years ago

Please see below side by side MaterialPods and OpenPods. Notice that toggling Location at the top (green circle) disables OpenPods while MaterialPods keeps working. Both apps are granted location permission.

Screenshot_20200309-174438_Nova Launcher Screenshot_20200309-174420_Nova Launcher

adolfintel commented 4 years ago

I removed that check, does this APK work for you? app-release.zip

maxim-saplin commented 4 years ago

That was super fast) Yep, works like a charm!

adolfintel commented 4 years ago

On today's episode of google changes random shit in android...

maxim-saplin commented 4 years ago

Lol:) Thanks a lot!