adolfintel / OpenPods

The Free and Open Source app for monitoring your AirPods on Android
https://fdossena.com/?p=openPods/index.frag
GNU General Public License v3.0
938 stars 161 forks source link

Notification layout issues in #65 #68

Closed adolfintel closed 4 years ago

adolfintel commented 4 years ago

@Electric1447 I merged your PR since it works well, however I noticed two issues with the new notification layout:

Screenshots: Screenshot_20200524-073834_Lawnchair Screenshot_20200524-073921_LineageOS_Settings

I'm sure I can fix those issues myself but since it's your PR, it's probably best if you could do this to avoid introducing other glitches.

Electric1447 commented 4 years ago

I'll work on it

Electric1447 commented 4 years ago

For the life of my me I can't recreate this bug.

Screenshot_20200524-092832

Screenshot_20200524-092810

Maybe try to reinstall the app and test further. (Btw which Android version are you on?)

Electric1447 commented 4 years ago

This might be an issue for Android 9 and lower

adolfintel commented 4 years ago

Hmm, yes, it could be only on older versions of Android, I'm still using Android 9. If you can find some workaround for the background color, do it, otherwise just force the notification to be white if the SDK is <29 I guess.

The charge icon problem I think is caused by the space below the pod image being too narrow when it says 100%

Electric1447 commented 4 years ago

I created a possible fix, However I don't have an older Android phone charged up rn (and the default avd is crap) so please test it yourself.

Electric1447 commented 4 years ago

It is not a major change the only thing changed is to force the notification background to update with the notification text. (Google/Android should really have a more developer friendly dark theme before hyping their broken dark mode)

adolfintel commented 4 years ago

It works :)

adolfintel commented 4 years ago

I merged #69 since it works. Can you fix the charge icon as well?

Electric1447 commented 4 years ago

First I'll need to charge my Airpods ;)

Electric1447 commented 4 years ago

I fixed the charge icon in #70

adolfintel commented 4 years ago

All issues seem to have been resolved. I'll test the app for a few days to make sure that I don't run into problems (most importantly, I want to make sure that the service sticks), then 1.4 is ready for release.