search

adolfintel / OpenPods

The Free and Open Source app for monitoring your AirPods on Android
https://fdossena.com/?p=openPods/index.frag
GNU General Public License v3.0
970 stars 164 forks source link

Text-only notification mode (for 1.5) #72

Closed Electric1447 closed 4 years ago

Electric1447 commented 4 years ago

This pr adds a smaller text-only notification mode as requested in #41

This mode is only available on Android Oreo and higher. The only way to make the notification even smaller is to set it's importance to _IMPORTANCE_MIN_, however because google is annoying again if we change the importance to be lower we cannot increase it back within the app. So when the user clicks on the text-only option in the app settings, It displayes a popup window which explains how to enable the text-only mode and takes the user to the notification settings in the android settings app. This mode works by detecting the notification importance in PodsService.java and acting appropriately.

This is very experimental and thus shouldn't be included in version 1.4 Please only merge after releasing version 1.4

(I also need to update the translations for the new strings but I'm too lazy today)

adolfintel commented 4 years ago

Thanks for all your contributions. I have to say, I'm not a fan of the text only notification, especially with that priority limitation, it kinda ruins the user experience so I'm not sure about merging this in 1.5 Looking forward to the widget though :)

Electric1447 commented 4 years ago

I'm also not really that much a fan of it, I thought it would be good to still put it up.

Maybe we put all of this "Experimental" features on a different branch.

adolfintel commented 4 years ago

I'd recommend doing a separate branch for each feature you want to implement, that way it will be easier to merge only the ones that we want to keep.

Electric1447 commented 4 years ago

On a different note please add the enchment label to new feature ideas in the issues.

And also create an Experimental, Translation, Bug fixes and General Improvements labels for better organization of pull requests.

adolfintel commented 4 years ago

Right, I'll create the labels

Domi04151309 commented 4 years ago

Issue templates could automate the process of adding labels

Electric1447 commented 4 years ago

I'd recommend doing a separate branch for each feature you want to implement, that way it will be easier to merge only the ones that we want to keep.

Time to watch some tutorials on how you use github branches lol

adolfintel commented 4 years ago

Send me an email if you need help :)

Electric1447 commented 4 years ago

I moved the new changes to a new branch Electric1447:experimental

adolfintel commented 4 years ago

@Electric1447 do you want to merge this to master or keep it in experimental?