adolfintel / OpenPods

The Free and Open Source app for monitoring your AirPods on Android
https://fdossena.com/?p=openPods/index.frag
GNU General Public License v3.0
932 stars 161 forks source link

Add special values for Android > 9 #77

Closed Domi04151309 closed 4 years ago

Domi04151309 commented 4 years ago

Related to #76 Works as intended on Android 10. Not tested on lower versions.

adolfintel commented 4 years ago

Awesome. I'll test it on Android 9 and see if it works properly

adolfintel commented 4 years ago

That seems to work just fine. Thanks!

Electric1447 commented 4 years ago

Are you sure it properly works on Oreo and older?

adolfintel commented 4 years ago

It displays correctly on my phone with Android 9, I don't have anything older to test it though.

Electric1447 commented 4 years ago

I do have my old S8 for testing, would report back if any issues occur

Domi04151309 commented 4 years ago

I'm pretty sure that won't make a difference. It's more like a division between > 9 and ≤ 9.

Electric1447 commented 4 years ago

Android 8 handles dark theme differently than 9 and 10. So dark theme is really dependent on the Android version and rom.

Domi04151309 commented 4 years ago

Yes but the pull request doesn't change any values for versions below 9. So if it worked before it should still work.

Electric1447 commented 4 years ago

I did not notice this, you are correct.