(these pull requests are done to maintain ally 4.1... someone is still using this probably)
Proposed changes
Profile picture via Facebook graph API is no longer possible. Profile picture is actually already returned when we get user profile from Facebook, under picture.data.url
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
thetutlage
commented
3 years ago
(these pull requests are done to maintain ally 4.1... someone is still using this probably)
Proposed changes
Profile picture via Facebook graph API is no longer possible. Profile picture is actually already returned when we get user profile from Facebook, under picture.data.url
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...