adonisjs / ally

AdonisJS Social Authentication Provider
MIT License
158 stars 54 forks source link

feat: add discord driver #120

Closed Mesteery closed 3 years ago

Mesteery commented 3 years ago

Proposed changes

Add the Discord OAuth2 driver.

Types of changes

Checklist

thetutlage commented 3 years ago

Appreciate you taking out time to add proper types as well. Going to give it a test run in a while :)

thetutlage commented 3 years ago

Hey, the tests are failing coz there are styling issues. https://github.com/adonisjs/ally/pull/120/checks?check_run_id=2704363449

Just run npm run format and then push the code

Mesteery commented 3 years ago

Yes, I saw that the CI failed. However, in local the tests pass.

thetutlage commented 3 years ago

Did you try to run npm run format and see anything change?

Mesteery commented 3 years ago

Yes, there are no change. Also, my branch is up to date with the remote. I'll retry anyway.

Mesteery commented 3 years ago

It worked (on my another machine), I don't understand why it didn't work before. Sorry.

thetutlage commented 3 years ago

Looks good. Thanks for the PR :)