Closed Mesteery closed 3 years ago
Appreciate you taking out time to add proper types as well. Going to give it a test run in a while :)
Hey, the tests are failing coz there are styling issues. https://github.com/adonisjs/ally/pull/120/checks?check_run_id=2704363449
Just run npm run format
and then push the code
Yes, I saw that the CI failed. However, in local the tests pass.
Did you try to run npm run format
and see anything change?
Yes, there are no change. Also, my branch is up to date with the remote. I'll retry anyway.
It worked (on my another machine), I don't understand why it didn't work before. Sorry.
Looks good. Thanks for the PR :)
Proposed changes
Add the Discord OAuth2 driver.
Types of changes
Checklist