adonisjs / ally

AdonisJS Social Authentication Provider
MIT License
159 stars 53 forks source link

feat: add facebook driver #121

Closed irwing-reza closed 3 years ago

irwing-reza commented 3 years ago

Proposed changes

Add Facebook diver

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

thetutlage commented 3 years ago

Looks great. Can you please rebase your branch with the latest develop branch, as there are merge conflicts in your PR?

irwing-reza commented 3 years ago

Branch has been updated.

thetutlage commented 3 years ago

Looks great. Thanks for taking out the time to contribute 🙂