Closed romch007 closed 3 years ago
Small question, I find it strange the port is hard-coded, given that the PORT
environment variable is used elsewhere, especially for callbackUrls
https://github.com/adonisjs/ally/blob/3891b85d1b362c7a16cd26c85a3ca02d470964d5/examples/app.ts#L14
Small question, I find it strange the port is hard-coded, given that the
PORT
environment variable is used elsewhere, especially for callbackUrls
Seems like a mistake, feel free to fix it in the same PR
Thanks a ton for putting in the work :)
Proposed changes
I added a Spotify driver. Informations about Spotify OAuth : https://developer.spotify.com/documentation/general/guides/authorization-guide/
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments