adonisjs / ally

AdonisJS Social Authentication Provider
MIT License
159 stars 53 forks source link

Add Apple Sign In driver #125

Closed bitkidd closed 3 years ago

bitkidd commented 3 years ago

Proposed changes

This PR adds support for Apple Sign In service.

Types of changes

What types of changes does your code introduce?

Checklist

Further comments

Apple requires developers to include their sign in service into the apps when there are other social sign in services so it may be useful to add this driver.

thetutlage commented 3 years ago

Alright. So I have been reading the Apple documentation and it seems like their implementation is little more complicated.

Now, the thing is, I don't have an apple developer account to test the implementation or even more I am concerned with maintaining it in the future (when you might not be available).

To be honest, I would like to skip adding the apple driver to the package directly, as I will have to maintain something that I cannot even test without paying 100$ to apple every year.

We can create it as a separate package based on this ally-boilerplate repo and I am happy to keep it inside the adonisjs-community org on Github and you can be maintainer of it.

bitkidd commented 3 years ago

Absolutely agree, as their dev system is closed it may not allow someone without dev account test driver implementation. I will extract it to a separate provider.

As I will do this, will notify you to migrate repo into community org. Thank you!

thetutlage commented 3 years ago

Closing. Since we decided to keep it outside the core