Fixed missing `identify` scope for Discord OAuth2

Bricklou commented 3 years ago

Proposed changes

Just added identify scope to the default required scopes. Without this identify scope, the Discord API throw an "Unauthorized" (401) error. Fix #127

Types of changes

Bug fixing

What types of changes does your code introduce?

Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

thetutlage commented 3 years ago

Can you please open another PR mentioning that the user call will fail, if someone defines custom scopes and do not add identity in it?

Bricklou commented 3 years ago

On the documentation you mean ?

thetutlage commented 3 years ago

Yup. For docs. Here's the link to the repo https://github.com/adonisjs/docs.adonisjs.com

thetutlage commented 3 years ago

Thanks for the PR :)

adonisjs / ally