adonisjs / ally

AdonisJS Social Authentication Provider
MIT License
158 stars 54 forks source link

Add twitch provider #129

Closed mrgmnn closed 2 years ago

mrgmnn commented 2 years ago

Proposed changes

I have been working with adonis for long time now and love it. I have an old project which I am now moving to adonis5. I had integrated twitch 0auth by myself until I now stumbled upon your package. Sadly I noticed twitch integration is missing so I decided to implement it myself. So here it is.

Types of changes

Adding Twitch 0auth integration

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

thetutlage commented 2 years ago

@bombelflotz Thanks for the contribution. But I think this should be maintained as a community package. The reasoning is, I do not use and also not familiar with twitch, so it will become kind of hard for me in the future to maintain this driver.

We already have a few community managed Ally drivers.

To get started we have created this boilerplate https://github.com/adonisjs-community/ally-driver-boilerplate

mrgmnn commented 2 years ago

@thetutlage Ok. That's a little sad since twitch is one of the bigger platforms right now but I see your point. I create a community package

thetutlage commented 2 years ago

Thanks for understanding. I will close this PR for now

ErriourMe commented 2 years ago

@bombelflotz Thanks for the contribution. But I think this should be maintained as a community package. The reasoning is, I do not use and also not familiar with twitch, so it will become kind of hard for me in the future to maintain this driver.

We already have a few community managed Ally drivers.

To get started we have created this boilerplate https://github.com/adonisjs-community/ally-driver-boilerplate

Please put it in readme file. It's very helpful information but I had to find it on the internet (and no info on google btw) :)