feat: implement guilds getter to work with scope for Discord

adonisjs / ally

AdonisJS Social Authentication Provider

MIT License

159 stars 53 forks source link

feat: implement guilds getter to work with scope for Discord #130

Closed goustkor closed 2 years ago

goustkor commented 2 years ago

Proposed changes

This allows the user to get the guilds he is currently present when using the scope "guilds"

const discord = ally.use('discord')

const guilds = await discord.guilds()`

Types of changes

What types of changes does your code introduce?

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

thetutlage commented 2 years ago

Outside the scope of the package as there is no limit to what resources you can/want to fetch for the user. For example: Someone may later ask to fetch the friends of a user on Facebook or Repos of a user on Github.

You can simply implement this function within your codebase by using the access token

goustkor commented 2 years ago

I agree with you about the part I can implement in my own code. But I believe that maybe bringing these features would make the package more robust.

But if you think it could become too overwhelming to maintain then I understand.

thetutlage commented 2 years ago

Thanks for understanding. Yes, I want to avoid adding APIs that are applicable to only one driver.