fix(twitter): fetch id_str and https picture

HapLifeMan commented 6 years ago

Proposed changes

Fixes few bugs: bad ID and HTTP profile pictures URIs were fetched.

Replaced id to id_str because it wasn't used correctly as an integer.
Fetched profile_image_url_https
Improved "_normal" replacement (sometimes you can have .png or .gif profile pictures).

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

coveralls commented 6 years ago

Coverage remained the same at 67.033% when pulling bf28c5ccddc9f07ef9cce220e529613472abc351 on HapLifeMan:develop into 16dfd3c5a1b7835f00a5da85d00ff54ffa55475f on adonisjs:develop.

thetutlage commented 6 years ago

Looks great. Thanks 😄

thetutlage commented 6 years ago

Published as 2.1.2.

adonisjs / ally

fix(twitter): fetch id_str and https picture #60

Proposed changes

Types of changes

Checklist