search

adonisjs / ally

AdonisJS Social Authentication Provider
MIT License
159 stars 53 forks source link

Update package.json #61

Closed isocroft closed 5 years ago

isocroft commented 5 years ago

Proposed changes

This PR adds a change to the version of the got library used by ally to make requests from v8.3.2 to v9.3.2. v9.3.2 is more stable and has a smaller install size (248kB) all the way from (578kB). see: Releases Page for got. I believe this is a great reason to release a new version of ally with got v9.3.2 (latest version). This introduces a breaking change (NodeJS v8 is no longer supported with got v9.x) so i have to bump up the major version to 3 for ally

Types of changes

A New Feature that leads to a smaller package requirements size.

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

isocroft commented 5 years ago

Please, how soon can this be published to npm ? I really need it for my AdonisJS project. This new version (v3.0.0) does not change the functionality of ally v2.1.2

Also, Thanks for a wonderful package as this

isocroft commented 5 years ago

ally package version now at 2.2.0

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 67.033% when pulling 0b65f015e4ef54c2de1bbf2c9aabfefe371f5096 on isocroft:package_ver_bump into 4e3902f4591bfc7642163bc91cc507a6a68fd1e2 on adonisjs:develop.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 67.033% when pulling 889216c06460d803729966765c05523f265ae5e4 on isocroft:package_ver_bump into 4e3902f4591bfc7642163bc91cc507a6a68fd1e2 on adonisjs:develop.