search

adonisjs / auth

Official Authentication package for AdonisJS
https://docs.adonisjs.com/guides/auth/introduction
MIT License
196 stars 64 forks source link

Missing expires_in #137

Closed n10000k closed 4 years ago

n10000k commented 5 years ago

Reference to #134

expires_in is missing from the response, this should not be inside the token and be at a top level to avoid applications spending time to decode the token.

RFC for OAuth2: https://tools.ietf.org/html/rfc6749 RFC Appendix: https://tools.ietf.org/html/rfc6749#appendix-A.14

thetutlage commented 5 years ago

The JWT scheme is not an implementation of OAuth2, so I will better ignore the spec.

However, I do have plans to replace it with fully fledged OAuth2 later

n10000k commented 5 years ago

You open to a PR for full OAuth2?

thetutlage commented 4 years ago

Closing since not actionable. Regarding OAuth2, I don't have any plans as of now, until there is a huge demand in the community