adonisjs / auth

Official Authentication package for AdonisJS
https://docs.adonisjs.com/guides/auth/introduction
MIT License
191 stars 65 forks source link

Update model.txt #153

Closed ConsoleTVs closed 3 years ago

ConsoleTVs commented 3 years ago

Proposed changes

The default user model should not expose password by default.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

thetutlage commented 3 years ago

Thanks 😄

ConsoleTVs commented 3 years ago

Hey @thetutlage , Thanks a lot for the merge, I'm still tinkering and I'm planning to improve a bit the docs & maybe internal code regarding adonis itself. As you know, we're undergoing hacktoberfest. Would it be possible to label this pull request as hacktoberfest-accepted in case you feel it was a well-enough work? I know it's not much of a change, but I had to dig a bit to find those compromises. I would understand if you didn't want to label it as such. There's also no need to set the project topic, marking a PR with that label is enough to help me towards this anual goal! Thanks a lot!