adonisjs / auth

Official Authentication package for AdonisJS
https://docs.adonisjs.com/guides/auth/introduction
MIT License
193 stars 65 forks source link

'guard' is never reassigned. Use 'const' instead. #225

Open leofmarciano opened 11 months ago

leofmarciano commented 11 months ago

Proposed changes

This pull request addresses the prefer-const issue identified in our codebase. The change involves modifying the guard variable declaration from let to const in the authentication loop, as this variable is never reassigned. This change aligns with the global standard "prefer-const" of using const for variables that will not be mutated later.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

The prefer-const rule is a widely accepted best practice in JavaScript and TypeScript development. It helps to prevent unintentional mutation of variables and makes the code easier to reason about. By making this change, we ensure that our code adheres to this best practice, making it more robust and maintainable.

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.