This pull request addresses the prefer-const issue identified in our codebase. The change involves modifying the guard variable declaration from let to const in the authentication loop, as this variable is never reassigned. This change aligns with the global standard "prefer-const" of using const for variables that will not be mutated later.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added necessary documentation (if appropriate)
Further comments
The prefer-const rule is a widely accepted best practice in JavaScript and TypeScript development. It helps to prevent unintentional mutation of variables and makes the code easier to reason about. By making this change, we ensure that our code adheres to this best practice, making it more robust and maintainable.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Proposed changes
This pull request addresses the prefer-const issue identified in our codebase. The change involves modifying the guard variable declaration from let to const in the authentication loop, as this variable is never reassigned. This change aligns with the global standard "prefer-const" of using const for variables that will not be mutated later.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
The prefer-const rule is a widely accepted best practice in JavaScript and TypeScript development. It helps to prevent unintentional mutation of variables and makes the code easier to reason about. By making this change, we ensure that our code adheres to this best practice, making it more robust and maintainable.