chore: add Basic auth guard - Githubissues

adonisjs / auth

Official Authentication package for AdonisJS

https://docs.adonisjs.com/guides/auth/introduction

MIT License

193 stars 65 forks source link

chore: add Basic auth guard #243

Closed parker-codes closed 6 months ago

parker-codes commented 6 months ago

🔗 Linked issue

No linked issue. Reported in Discord and Romain pointed me in the right place for a PR.

❓ Type of change

[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The docs described Basic Auth as one of the options, but the CLI wouldn't accept it.

node ace add @adonisjs/auth --guard=basic_auth

The selected guard "basic_auth" is invalid. Select one from: session, access_tokens

This PR just adds the missing guard to the config list and adds the type in the missing places.

Since many tests are already failing, I couldn't verify that this doesn't break anything.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

thetutlage commented 6 months ago

Thanks 👍