search

adonisjs / auth

Official Authentication package for AdonisJS
https://docs.adonisjs.com/guides/auth/introduction
MIT License
196 stars 63 forks source link

Using uuid.v4() instead of uuid.v1() #46

Closed ianwalter closed 7 years ago

ianwalter commented 7 years ago

The generate method modified in this change seems to be what is generating API (and session?) tokens. If this is the case, then I believe that using the v4() method instead of v1() would be more desirable as it would provide higher entropy and so be harder to reproduce. v4() is completely random while v1() is time-based.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 97.697% when pulling 987a1e1236ec72d0466976f399d125ba5488a1a9 on ianwalter:patch-1 into c6468f068cdb0522f15f51ef3d05bf51e4a6c174 on adonisjs:develop.

thetutlage commented 7 years ago

Thanks :)