feat(jwt): add login() method to jwt scheme

[radmen]

When using Jwt scheme auth.login(user) fails. It's due to lack of such method in Schemes/Jwt.

This PR introduces login() method which is an alias for generate().

[coveralls]

Coverage increased (+0.003%) to 98.381% when pulling 734cf6d64f5d96c5dd1d2f855580c24f3f696833 on radmen:login-alias-for-jwt-scheme into 8aa688685b7a3de35994a1c54b89fbb964cb3a72 on adonisjs:develop.

[thetutlage]

Ideally there should never be a login method in JWT, since login means, you have a stateful loggedin state, which is not true with JWT.

So it's fine to throw the exception and set right expectations

[radmen]

I took more detailed peek at the docs and found information about why there's a difference. I guess I can modify this PR so that login() will throw an exception.

[thetutlage]

But what make you think that login should work with JWT?

[radmen]

But what make you think that login should work with JWT?

• I consider Auth as a facade (as in Laravel) for underlying "drivers" (in this case - schemes). I simply assumed that login() is common for all schemes
• schemes have attempt(). I thought that, by analogy, there will be also login() method

[thetutlage]

When Laravel doesn't existed, in stateless auth, you cannot login ( which is way more important than reading the Laravel source code for me )

[radmen]

I'm using Laravel as an analogy.

Also, I think that if there's a facade (eg Auth) which acts as a proxy for underlying implementations those implementations should have a common interface.

If you think that Jwt::login() should not do anything, that's fine. Yet I think that this method should exist and simply tell the developer that one should use generate() instead.

[thetutlage]

Yes I am in favour of throwing a meaningful exception

[radmen]

Ok, I'll do it.

Should I update this branch, or create a new one with new PR?

[thetutlage]

You can update this branch itself

[radmen]

Ok, will do so. Thanks!

[radmen]

@thetutlage I've pushed update to PR. Now, login() will throw an exception.

[coveralls]

Coverage increased (+0.003%) to 98.381% when pulling 9f6fe35eaa98326b1dc4ece4847bcd4cecb6785a on radmen:login-alias-for-jwt-scheme into 8aa688685b7a3de35994a1c54b89fbb964cb3a72 on adonisjs:develop.

[thetutlage]

Looks great thanks 😄

[radmen]

Thank you :)