adonisjs / core

AdonisJS is a TypeScript-first web framework for building web apps and API servers. It comes with support for testing, modern tooling, an ecosystem of official packages, and more.
https://adonisjs.com
MIT License
16.96k stars 638 forks source link

No bson dependency #837

Closed nickelghost closed 6 years ago

nickelghost commented 6 years ago

Hello, after creating a new Adonis 4.1 app with the default scaffolding, and running it with adonis serve --dev, I'm getting the following error in the browser:

Error: Cannot find module 'bson'
Error: Cannot find module 'bson'
    at Function.Module._resolveFilename (module.js:543:15)
    at Function.Module._load (module.js:470:25)
    at Module.require (module.js:593:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/gabriel/Code/wololo/node_modules/@adonisjs/session/src/Session/Store.js:14:18)
    at Module._compile (module.js:649:30)
    at Object.Module._extensions..js (module.js:660:10)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:501:12)
    at Function.Module._load (module.js:493:3)

Installing bson with npm helps.

thetutlage commented 6 years ago

Thanks for reporting

Yeah a bad PR made into one of the latest releases. I fixed it and should be all good for new projects now.

Related commit https://github.com/adonisjs/adonis-session/commit/fd90a729fb36c83c02dae6216897982075f1c028

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.