adonisjs / drive-s3

S3 driver for AdonisJS drive
MIT License
21 stars 9 forks source link

feat: add getStreamRange for ranged stream #13

Closed Venipa closed 2 years ago

Venipa commented 2 years ago

Proposed changes

12

added getStreamRange with S3 supported Range property

https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/clients/client-s3/interfaces/getobjectrequest.html#range

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

thetutlage commented 2 years ago

Hello @Venipa

Thanks for creating the PR. However, it seems like this API method is only relevant with s3 and cannot be replicated with other adapters like local or gcs. Therefore, we cannot add it.

One of the goals of Drive is to have identical API across all the drivers.

Venipa commented 2 years ago

@thetutlage ye i ended up just using the adapter to send a custom get command image