fix: corrected misspelling of destination

adonisjs / logger

AdonisJS Logger built on top of pino

https://docs.adonisjs.com/guides/logger

MIT License

23 stars 9 forks source link

Closed mikesaintsg closed 3 months ago

mikesaintsg commented 4 months ago

[X] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

A quick fix, "destination" was misspelled as "desination", to correctly match the Pino config options

thetutlage commented 4 months ago

Seems like its going to be a breaking change. So we should actually keep the property name with typo, deprecate it and then re-map it internally.

mikesaintsg commented 4 months ago

How are deprecations being handled? Should an Error be thrown or some sort of console log?

RomainLanz commented 4 months ago

How are deprecations being handled? Should an Error be thrown or some sort of console log?