Closed mikesaintsg closed 3 months ago
Seems like its going to be a breaking change. So we should actually keep the property name with typo, deprecate it and then re-map it internally.
How are deprecations being handled? Should an Error be thrown or some sort of console log?
How are deprecations being handled? Should an Error be thrown or some sort of console log?
You should add a comment on top of the property. Example: https://github.com/adonisjs/auth/blob/a3b87aabde87ec7c1953955ed1fb8c437582d21d/index.ts#L29
❓ Type of change
📚 Description
A quick fix, "destination" was misspelled as "desination", to correctly match the Pino config options