fix(migrator): step option

adonisjs / lucid

AdonisJS SQL ORM. Supports PostgreSQL, MySQL, MSSQL, Redshift, SQLite and many more

https://lucid.adonisjs.com/

MIT License

1.02k stars 189 forks source link

fix(migrator): step option #1023

Closed MaximeMRF closed 2 months ago

MaximeMRF commented 2 months ago

❓ Type of change

[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)

📚 Description

Rollback the last migrations instead of rollback the firsts (that's make more sense)
Patch a little display bug due to the non-adaptation of this.migratedFiles at the step option

bug: DeepinScreenshot_select-area_20240403171308

now: DeepinScreenshot_select-area_20240403171553

thetutlage commented 2 months ago

Sorry, I did not get the issue. Is it reversing the order in which migrations are reverted? Or is it something related to the way logs are displayed?

MaximeMRF commented 2 months ago

Currently the migrator with the step flag rollback the migrations that are migrated firstly but it's make nonsens because we want to rollback the last ones.

And another problem was the display of the grey word "reverting" while all the concerning migrations was already reverted.