search

adonisjs / lucid

AdonisJS SQL ORM. Supports PostgreSQL, MySQL, MSSQL, Redshift, SQLite and many more
https://lucid.adonisjs.com/
MIT License
1.02k stars 189 forks source link

Relationship constraints are not being applied when using sub query in whereIn condition #1036

Open adamcikado opened 2 weeks ago

adamcikado commented 2 weeks ago

Package version

20.6.0

Describe the bug

When using relationship sub query in whereIn() condition, the constraints are not being applied.

For example:

Post.query().whereIn('id', user.related('posts').query().select('id'))

The user_id = ID clause is not being added in this case.

This issue occurs because applyConstraints() is not being called here https://github.com/adonisjs/lucid/blob/develop/src/database/query_builder/chainable.ts#L235.

I will create PR for this shortly.

Reproduction repo

No response