search

adonisjs / mail

AdonisJS Email Provider
MIT License
106 stars 34 forks source link

Add SendGrid driver #1

Closed nrempel closed 7 years ago

nrempel commented 8 years ago

This pull request adds a driver for SendGrid.

It uses https://github.com/sendgrid/nodemailer-sendgrid-transport to handle sending mail.

To test it, create a free sendgrid account and run:

SENDGRID_APIKEY=<api key> npm test
nrempel commented 8 years ago

You can check the mail that was sent here: https://www.guerrillamail.com/inbox

Set the inbox to adonis-sg@sharklasers.com

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-16.3%) to 80.769% when pulling ea2f96bc351236d17316bc9eebd54fd1c0b0a6e9 on nrempel:feature-sendgrid-support into 39797740714f68feeae5c66dd10cf6cca6f44b44 on adonisjs:develop.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-16.3%) to 80.769% when pulling ea2f96bc351236d17316bc9eebd54fd1c0b0a6e9 on nrempel:feature-sendgrid-support into 39797740714f68feeae5c66dd10cf6cca6f44b44 on adonisjs:develop.

nrempel commented 8 years ago

Hmm, not sure why coverage has decreased on some files. I've only added a new file and accompanying test.

nrempel commented 8 years ago

It looks like the full suite of tests is not running correctly. It seems to get cut off here https://travis-ci.org/adonisjs/adonis-mail/jobs/139555224#L658

thetutlage commented 8 years ago

There is a disclaimer saying sendgrid will not support the node-mailer transport post June 1st. So it does not make sense to use a deprecated library.

nrempel commented 8 years ago

Good point, I've updated the code to use the API directly.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-16.3%) to 80.769% when pulling 2efcf9693908b42688b5afb60075c661cea08034 on nrempel:feature-sendgrid-support into 39797740714f68feeae5c66dd10cf6cca6f44b44 on adonisjs:develop.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-16.3%) to 80.769% when pulling 2efcf9693908b42688b5afb60075c661cea08034 on nrempel:feature-sendgrid-support into 39797740714f68feeae5c66dd10cf6cca6f44b44 on adonisjs:develop.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-16.3%) to 80.769% when pulling 2efcf9693908b42688b5afb60075c661cea08034 on nrempel:feature-sendgrid-support into 39797740714f68feeae5c66dd10cf6cca6f44b44 on adonisjs:develop.

nrempel commented 8 years ago

@thetutlage why did you close this? I'm happy to make any changes you request.

thetutlage commented 8 years ago

Ooops sorry, I thought the PR is from greenkeeper. Let me go through the PR once again

nrempel commented 8 years ago

Ok thanks!

SAGV commented 7 years ago

@thetutlage @nrempel This still seems pretty useful…

thetutlage commented 7 years ago

Closing and will write SendGrid driver from scratch, quite a few things have changed and this library needs some cleanup, also with removing Mandrill driver

zooshme commented 6 years ago

Any news on a driver for SendGrid?

kush-prof commented 3 years ago

@thetutlage Are you planning to write the SendGrid driver soon for AdonisJs Mail, I can help with it if you are not planning in recent future?

emmsdan commented 10 months ago

@thetutlage I am hoping we will get to see Sendgrid in v6