Patch for working with Mailgun regions

alvisx commented 5 years ago

Proposed changes

Mailgun added opportunity of region selection in control panel. Currently available 2 regions: US and EU. Domains added in EU region is not visible in main API (US) because base URL for EU region is like https://api.eu.mailgun.net/v3/. Mailgun driver in Mail provider works wrong if domain situated in EU region.

Types of changes

Region defining in .env
Defining default region in _/config/mail.js_
Building url with region in src/Mail/Drivers/Mailgun.js

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

Further comments

No

coveralls commented 5 years ago

Coverage decreased (-11.2%) to 81.579% when pulling 771ddfa0e75f0c618a31bcc2b2ef47d64bd51ef2 on alvisx:patch-1 into c0f565a51c837a896da0a436ce3acd05f9634907 on adonisjs:develop.

RomainLanz commented 5 years ago

Hey @alvisx! 👋

Could you please update your message and fill the placeholder? 😃

alvisx commented 5 years ago

My next steps is writing tests or update PR with this changes?

thetutlage commented 5 years ago

Yes, tests will help that we aren't missing any edge cases

RomainLanz commented 5 years ago

Closing this PR since a similar one has been merged.

Reference: https://github.com/adonisjs/adonis-mail/pull/33

adonisjs / mail