Added missing 'sendLater' method

msrumon commented 4 years ago

Proposed changes

@thetutlage proposed me to make this PR w/ the changes. Full discussion can be found here.

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have read the CONTRIBUTING doc
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

Further comments

I'm not sure, I'm still in learning phase of writing type definitions for TypeScript projects. I hope I made the correct fix. :)

thetutlage commented 4 years ago

Hey @msrumon It's only the typing is missing. The sendLater method also needs to be implemented on MailManager, along with some tests :)

msrumon commented 4 years ago

Oh I see. That's why the tests have failed, right?

msrumon commented 4 years ago

Thanks for the fix. The doc says sendLater method pushes the emails to in-memory queue, but doesn't tell anything about how to push them to separate queue server. Can you add that as an example to the doc please? Or at least describe here?

adonisjs / mail