added the auth key to the smtp driver options

kennymark commented 4 years ago

Proposed changes

By default the smtp driver options do not have the auth key available even tho it is essential for every smtp option. This just makes it easier for install to simply use smtp without having to depend on intellisense of their code editors to know the auth key exists on the smtp driver.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have added necessary documentation (if appropriate)

Further comments

thetutlage commented 4 years ago

Hey @kennymark Thanks for the PR.

It will be nice to also define these environment variables inside the package.json file, so that they are added to the user .env file at the time of setup.

Also, I will rename them as SMTP_USERNAME and SMTP_PASSWORD

kennymark commented 4 years ago

Hey @kennymark Thanks for the PR.

It will be nice to also define these environment variables inside the package.json file, so that they are added to the user .env file at the time of setup.

Also, I will rename them as SMTP_USERNAME and SMTP_PASSWORD

I will do that if you dont mind later today

thetutlage commented 4 years ago

No at all. Take your time 😄

adonisjs / mail