search

adonisjs / tooling-config

Eslint, prettier, and typescript configurations for AdonisJS projects
2 stars 1 forks source link

ESLint configuration deprecated by the new ESLint 9 release #3

Open Bricklou opened 2 months ago

Bricklou commented 2 months ago

Package version

1.3.0

Describe the bug

With the new major release of ESLint, the config files structure changed completely to move into a new format: https://eslint.org/blog/2024/04/eslint-v9.0.0-released/ https://eslint.org/docs/latest/use/migrate-to-9.0.0

It seems that with this new format, old configurations can't work any more and need to be updated to support it.

Reproduction repo

No response

Julien-R44 commented 2 months ago

Thanks, will do it soon.

In fact, I am waiting for the Eslint Vscode extension to be released. Right now it's still in pre-release

https://github.com/microsoft/vscode-eslint/issues/1644#issuecomment-2041287658

MickL commented 2 weeks ago

I just migrated my monorepo (also containing Nuxt) to Eslint flat conigs and have no more eslint config for Adonisjs. Would absolutely appreciate a flat config :)

I am not a VS Code user but according to the Nuxt docs you can enable it with the eslint.experimental.useFlatConfig setting

Bricklou commented 2 weeks ago

No, now it is eslint.useFlatConfig if it hasn't been already detected. But the pre-version of vscode-eslint is still required

luffynando commented 1 week ago

Vscode extension is released https://github.com/microsoft/vscode-eslint/issues/1644#issuecomment-2173587025