Broadcastable type doesn't support array

adonisjs / transmit

A Server-Sent-Event module for AdonisJS

MIT License

71 stars 5 forks source link

Broadcastable type doesn't support array #23

Closed EvanPerreau closed 4 months ago

EvanPerreau commented 4 months ago

Package version

1.0.1

Describe the bug

the type Broadcastable doesn't support array

Reproduction repo

No response

RomainLanz commented 4 months ago

Hey @EvanPerreau! 👋🏻

It seems to be a type issue. Can you confirm if the code works despite the typing error?

EvanPerreau commented 4 months ago

Hello @RomainLanz,

Thanks for your reactivity. Yes, the code works perfectly except for the type error. Currently, I am using the //@ts-ignore annotation to avoid the type error. I am trying to pass an array in the transmit broadcast in a simple chat app, and it works perfectly ;)

It would be great if you could patch the bug. If you want, I can patch the bug and make a pull request to this repo.

RomainLanz commented 4 months ago

Yes, happy to accept a PR!

EvanPerreau commented 4 months ago

I fix this bug in the pull request #24 ;)