search

adonisjs / v5-docs

📚 Source code and documentation for the official docs website.
https://v5-docs.adonisjs.com
88 stars 138 forks source link

feat: increasing content width #194

Closed RomainLanz closed 2 years ago

RomainLanz commented 2 years ago

Hey there! 👋🏻

I have always thought that the text was a bit too narrowed. This PR increased the content width to 70ch, which is still within the recommended value.

thetutlage commented 2 years ago

I know you have a huge monitor, but how does it look like on a small screen? Can you share some screenshots?

RomainLanz commented 2 years ago

This is the result on a 14" Macbook Pro (without scaling).

CleanShot 2022-10-24 at 08 49 58@2x
targos commented 2 years ago

@thetutlage you can test the preview at https://feat-text-width.adonisjs-official-docs.pages.dev/

targos commented 2 years ago

BTW, I don't know if it's related to this change but there's a non-ideal breakpoint around 1300px:

image

RomainLanz commented 2 years ago

BTW, I don't know if it's related to this change but there's a non-ideal breakpoint around 1300px:

Yes, there are a few breakpoints where the content is 100%, and the aside or sidebar is not removed yet.

We have multiple options to avoid that:

  1. We lower the content width a bit.
  2. We add some padding when needed
  3. We remove the aside and sidebar earlier
cloudflare-workers-and-pages[bot] commented 2 years ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d66c381
Status: ✅  Deploy successful!
Preview URL: https://60de9d86.adonisjs-official-docs.pages.dev
Branch Preview URL: https://feat-text-width.adonisjs-official-docs.pages.dev

View logs

RomainLanz commented 2 years ago

So I have added some margins to avoid having the content glued to the edges.