object().members() accept properties that are not defined

[technoknol]

Package version

5.9.0

Node.js and npm version

node: 16.15.0 , npm: 8.5.5

Sample Code (to reproduce the issue)

Schema

{
     profile: schema.object().members({
        username: schema.string(),
        avatar_url: schema.string()
      })
}

Request Payload

{
     profile: {
        "asdfasd": "afasd",
        "username": "asfasd",
        "avatar_url": "asfsad"
     }
}

This validation passes and doesn't throw an error even if asdfasd is neither defined nor anyMembers is used.

[RomainLanz]

Hey @technoknol! 👋🏻

This is the expected behavior. The validated data will not have the properties you have not defined in your schema.

const data = {
  username: 'romain.lanz',
  avatar_url: 'http',
  wrong: true
}

const validatedData = await validator.validate({
  schema: schema.create({
    profile: schema.object().members({
      username: schema.string(),
      avatar_url: schema.string()
    }),
  }),
  data,
});

Here, validatedData will not have the wrong property.