Closed paoloevan closed 1 year ago
Hey @paoloevan! 👋🏻
Thanks for your work!
Seems that there are two PRs adding the same feature. (https://github.com/adonisjs/validator/pull/176) Would you mind if we go ahead with the one from MaximeMRF, as it seems more complete?
Hi! Sure @RomainLanz
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...