Open odparraj opened 1 year ago
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@RomainLanz Is it possible to review this, I would like to stop using the fork
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Proposed changes
Including the luxon date time options increases the developer's possibilities in other scenarios, here are some of them:
It is required to receive a date in ISO format and the validation result must return the time zone specified by the developer (ex: UTC):
{ published_at: schema.date({ format: 'iso', opts: { zone: 'UTC' } }) }
input: 2023-09-28T17:05:05.903-04:00
output: 2023-09-28T21:05:05.903Z
It is required to receive a date in ISO format and the validation result to return a DateTime object with the same input time zone, not necessarily the default time zone as it currently works, (assume default time zone in UTC):
{ published_at: schema.date({ format: 'iso', opts: { setZone: true } }) }
input: 2023-09-28T17:05:05.903-04:00
expected output equals to input: 2023-09-28T17:05:05.903-04:00
current output: 2023-09-28T21:05:05.903Z
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...