adonisjs / vow

Test Runner For AdonisJs
MIT License
56 stars 18 forks source link

Filter test files using "includes" instead of "equals" #61

Open MZanggl opened 4 years ago

MZanggl commented 4 years ago

Proposed changes

Testing a single file currently requires you to specify the entire file name, including the file extension. E.g.

adonis test -f 'UserService.spec.js'

With this fix in place, simpy UserService or even User would be enough. This then nicely aligns with the way grep works

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+1.3%) to 82.422% when pulling d8ffabf57b1d9b6266513e5f3fa52b206d3e463a on MZanggl:feature/filter-files-contains into 4a461e2144c4ea8bf9b7a5477916cb81c029dc63 on adonisjs:develop.

RomainLanz commented 4 years ago

Hey @MZanggl!

Thanks for your contribution! Could you please add some tests that cover your change.

@thetutlage Do you believe we should consider this as breaking change?

MZanggl commented 4 years ago

@RomainLanz I just added tests. I moved the filter part to the cli so now all the filtering is together in one place and became easy to test.