fix: add missing dependency on `@adonisjs/http-server`

adonisjs / web-starter-kit

Starter kit for creating traditional server rendered applications using AdonisJS

18 stars 7 forks source link

fix: add missing dependency on `@adonisjs/http-server` #3

Closed innocenzi closed 7 months ago

innocenzi commented 7 months ago

Type of change

[x] 🐞 Bug fix (a non-breaking change that fixes an issue)

Description

I spinned up a new v6 project to try out Adonis. The app/exceptions/handler.ts file uses @adonisjs/http-server, which was not included in the starter kit, so there were type errors (and probably runtime errors if I ran the code?).

Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

Julien-R44 commented 7 months ago

Oops. Thanks for the PR, but we should import these types from @adonisjs/core/types/http instead. @adonisjs/http-server is included in @adonisjs/core and does not need to be installed in the user application

innocenzi commented 7 months ago

Oh, okay, makes sense. Thanks!