search

adonno / tagreader

Simple to build/use NFC tag reader, specially created for Home Assistant
https://adonno.com
GNU General Public License v3.0
1.13k stars 176 forks source link

allow playlist in NDEF url #156

Closed luka6000 closed 2 years ago

luka6000 commented 2 years ago

This modification will allow to read Spotify and Apple Music playlist url from NDEF tag and use it in HA incoming as event music_tag. Additionally, there is a write_music_tag service which allow to write any url as NDEF on the tag

adonno commented 2 years ago

@jesserockz mind having a look please ?

luka6000 commented 2 years ago

sorry guys, I've completely refactored the code to parse the tag data only once. Now it's more clean and works as expected.

adonno commented 2 years ago

Changes overall look good. Just depends if you want to include them in the main repo YAML @adonno ?

@jesserockz I thought that could be useful since a lot of people want to use it as a jukebox and would you advise against it ? if so we could create a second YAML for jukebox only

jesserockz commented 2 years ago

@adonno No I have nothing against adding this into the main YAML. I do think it would make it easier for people to then use unmodified.