adoolnuc / nmodbus

Automatically exported from code.google.com/p/nmodbus
0 stars 0 forks source link

Addresses are short #20

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1.Try to use an address that is not a short value

What is the expected output? What do you see instead?

I have no expected output, I more cannot access many of the parameters in
my device because the Addresses don't start until 0x9100 or 37127. 

What version of the product are you using? On what operating system?

NModbus 1.4.0.2 windows XP professional SP2

Please provide any additional information below.

The code is very complicated and I wanted to just modify it myself but I am
afraid that if I boil it down to the ModbusMessageImpl class and change the
variable type then I will break compatibility everywhere else in the library.

I am not really asking for a fix it just seems strange that the library
would limit you to reading registers below 32767. I know that is a large
number but I have encountered more than one instance of a device with
register addresses above this number.

I would gladly change it myself to an integer but I was hoping that someone
could outline   briefly how the startAddress variable interacts with the
actual construction of the message. I was afraid that if I were to just
change it that it would no longer encode properly because I would be
changing to a 32 bit value. 

I could change it to a uShort that would give me a true 16 bit value
without affecting message packaging, I think but I was hoping someone could
confirm this for me.

Any attention to this would be greatly appreciated.

and thank you for creating such a nice library, and allowing the community
as a whole to use it. 

Original issue reported on code.google.com by EconomyP...@gmail.com on 2 Nov 2007 at 5:06

GoogleCodeExporter commented 9 years ago
Yeah sorry I am a dummy.

Please disregard the above and keep up the very good work.

Original comment by EconomyP...@gmail.com on 2 Nov 2007 at 5:14

GoogleCodeExporter commented 9 years ago

Original comment by sja...@gmail.com on 2 Dec 2007 at 1:31