search

adopted-ember-addons / ember-changeset

Ember.js flavored changesets, inspired by Ecto
http://bit.ly/ember-changeset-demo
MIT License
431 stars 141 forks source link

moment converts to proxy on changeset creation #629

Closed bgolla closed 2 years ago

bgolla commented 2 years ago

Version

"ember-changeset": "^4.0.0-beta.1",
"ember-changeset-validations": "4.0.0-beta.2",

Test Case

Steps to reproduce

let x = new Changeset({ foo: moment() });
console.log(x.foo instanceof moment); // returns false
console.log(x.foo); //returns Proxy {changes: {…}, content: Moment, proxy: Proxy, safeGet: ƒ, isObject: ƒ, …}

Expected Behavior

Returns moment instance instead

Actual Behavior

Returns Proxy

snewcomer commented 2 years ago

@bgolla Thank you! Is there a minimal test and failing assertion (using this repository's test suite) that shows this bug?

snewcomer commented 2 years ago

@bgolla https://github.com/poteto/ember-changeset/pull/636#issuecomment-1064763004

snewcomer commented 2 years ago

https://github.com/poteto/ember-changeset/issues/628#issuecomment-1065797210

Lmk if you have any other comments!

veelci commented 10 months ago

@snewcomer Why did you close this? Nothing has been done to fix this issue.