Add onDestroy callback method for flash object destroy

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli

https://www.npmjs.com/package/ember-cli-flash

MIT License

355 stars 113 forks source link

Add onDestroy callback method for flash object destroy #211

Closed scanieso closed 7 years ago

scanieso commented 8 years ago

This PR adds a callback function that can be passed in and called when a flash is destroyed.

[x] Add callback method handler
[x] Add unit test for destroyed flash object
[x] Update README for how to use callback

Addresses: https://github.com/poteto/ember-cli-flash/issues/212

homu commented 7 years ago

:umbrella: The latest upstream changes (presumably f5002eb) made this pull request unmergeable. Please resolve the merge conflicts.

patrickng commented 7 years ago

Ran into a scenario where I need this functionality - @scanieso This looks a couple months old, would you by any chance have time to fix the merge conflicts so that the collaborators can merge it? If not, I can clean it up for merge.

scanieso commented 7 years ago

Thanks for the ping @patrickng . Updated and ready for review.

patrickng commented 7 years ago

Thank you @scanieso and @sbatson5 !