search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

leave message on mouseover if sticky #223

Closed sbatson5 closed 7 years ago

sbatson5 commented 7 years ago

Fixes: https://github.com/poteto/ember-cli-flash/issues/222

The method to defer our timers wasn't checking to see if that object was sticky. This PR adds an early return to the timer methods and test to ensure they are not called.

mnoble01 commented 7 years ago

@sbatson5 any plans for a patch release soon? I just ran into this issue in production code.

sbatson5 commented 7 years ago

@mnoble01 The PR is open for 1.4.1. Unfortunately, I don't have npm access, so I can't publish it myself. Will ping @poteto.

In the meantime, you can reference the commit directly in your package.json as a temporary solution.

"ember-cli-flash": "poteto/ember-cli-flash#942e4375c8ffb0a0a93f4adbc236fe94ce708ae1"

mnoble01 commented 7 years ago

Thanks, @sbatson5

sbatson5 commented 7 years ago

@mnoble01 looks like 1.4.1 is published thanks to @Dhaulagiri

mnoble01 commented 7 years ago

@sbatson5 Yes, thanks to you both for the quick turnaround. I've already upgraded to 1.4.1 👍.