adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

Add a demo page ready to deploy to GH pages #226

Closed WillEngler closed 6 years ago

WillEngler commented 7 years ago

WIP to close #45.

Important changes:

Blocking issue:

If you check out my example example (ha) you'll notice that the messages never disappear. When I do a fresh clone, install, and ember serve of poteto/ember-cli-flash I see similar behavior on the existing test app. The existing dummy app does not explicitly set a timeout, so the timeout should be 3000 ms. But when I run the original dummy app, the messages hang around indefinitely. Do others see this behavior on a fresh install? It seems implausible that I'd be the first to notice a bug preventing timeouts from working, but I don't know where to start looking for the problem in the dummy app.

WillEngler commented 7 years ago

Just now seeing 49d2d593ed7a431420f8632f057c0c681ec023bc. So the groundwork had been laid for this a while back.