adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

extendedTimeout doesn't work when sticky equals true #228

Closed krachtstefan closed 6 years ago

krachtstefan commented 7 years ago

The extendedTimeout option seems not to work when sticky:true. Can anyone confirm this?

sbatson5 commented 7 years ago

@krachtstefan can you clarify? extendedTimeout is meant to give an extra padding to the amount of time for the message to disappear and adds the exiting class. When sticky is true, the message won't exit.

Are you looking to have the extendedTimeout apply when yo u click the message away?

krachtstefan commented 7 years ago

Are you looking to have the extendedTimeout apply when yo u click the message away?

Yes, my goal is to add animation when someone clicks a message away.

wcurtis commented 7 years ago

Just encountered this as well - goal is that messages that are dismissed by tap should have the same exit animation as those that are removed after a timeout.

sbatson5 commented 7 years ago

@krachtstefan & @wcurtis I had always used the clicking as an immediate dismissal but it shouldn't be too tough to add the same behavior. PR's are definitely welcome :) but I can try to find some time this weekend

wcurtis commented 7 years ago

@sbatson5 🙌

zion commented 7 years ago

+1