search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

extendTimeout on sticky message #240

Closed sbatson5 closed 6 years ago

sbatson5 commented 7 years ago

Closes: https://github.com/poteto/ember-cli-flash/issues/228

What's in this PR?

This PR adds the exiting class to messages that are sticky but have an extended timeout. This will honor exiting animations for messages that are clicked to dismiss.

Sticky message being dismissed with styling applied to exiting class: exiting-message

sbatson5 commented 6 years ago

@sdhull you had mentioned wanting address the issue of exiting animations when messages are sticky. Would you have time to review this PR using ember-concurrency to handle that? Finally got around to wrapping it up 😛

sdhull commented 6 years ago

One note: should remove my note in the Readme about .exiting not working with stick: true 😉

sbatson5 commented 6 years ago

@Dhaulagiri or @poteto mind giving this a review before I merge?

Dhaulagiri commented 6 years ago

@sbatson5 without being too familiar with ember-concurrency (somehow have not used it) this looks ok to my eyes