search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

extendTimeout on sticky message #254

Closed Dhaulagiri closed 6 years ago

Dhaulagiri commented 6 years ago

@sbatson5 I ended up reverting #240 because when reviewing I overlooked the fact that adding ember-concurrency required that dependency to be included in dependencies and not devDependencies. When I pulled 1.6.0 into our app it broke looking for ember-concurrency. Given this new information I'm wondering if there is a way to accomplish what you are doing here without ember-currency? Requiring consumers of ember-cli-flash to include it if they aren't already using it (as we are not) quadruples the size of this addon which is something I'm hesitant to do.

sbatson5 commented 6 years ago

Ah, that's why I didn't see it when we pulled it into our existing app (we already had concurrency).

We can find another solution with the run loop, it will just require more cleanup when destroying the component.

sbatson5 commented 6 years ago

@Dhaulagiri Updated this PR to use the run loop instead of concurrent tasks. I've tested it a few times and everything seems to be working as expected. Would you be able to pull it into a project and double check?

Dhaulagiri commented 6 years ago

Worked great in our app 👏

Dhaulagiri commented 6 years ago

:shipit:

sbatson5 commented 6 years ago

Merged! Think we could cut another release?

Dhaulagiri commented 6 years ago

Released in 1.6.2